Add support for Visual Studio 2026 by hwangsihu · Pull Request #2509 · DOCGroup/ACE_TAO

hwangsihu · 2026-03-04T09:42:15Z

Summary by CodeRabbit

New Features
- Added official support for Visual Studio 2026, including updated toolset handling and new project templates/configurations.
Chores
- Expanded Windows CI to run VS2026 build configurations.
- Added new build/configuration fragments to enable VS2026 builds and feature flags.
Documentation
- Updated release notes announcing Visual Studio 2026 support.

coderabbitai · 2026-03-04T09:42:47Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4af04f1f-bf71-4905-840f-33aeecb70719

📥 Commits

Reviewing files that changed from the base of the PR and between a0b4738 and 0e0c29f.

📒 Files selected for processing (3)

.github/workflows/cmake.yml
.github/workflows/windows.yml
ACE/NEWS

✅ Files skipped from review due to trivial changes (1)

ACE/NEWS

🚧 Files skipped from review as they are similar to previous changes (2)

.github/workflows/cmake.yml
.github/workflows/windows.yml

Walkthrough

Added Visual Studio 2026 support across CI, build tooling, and ACE configuration: new CI matrix entries, new MSVC 14.5 config header and gating, VS2026 MakeProjectCreator feature and nmake files, and a NEWS entry documenting the addition.

Changes

VS2026 support (CI, MSVC config, MakeProjectCreator, docs)

Layer / File(s)	Summary
CI matrix entries `.github/workflows/cmake.yml`, `.github/workflows/windows.yml`	Add VS2026 entries to the GitHub Actions matrices: new `vs2026` toolset using `windows-2025-vs2026` runner and x64 Debug/Release variants (vcpkg settings preserved).
MSVC config header and gating `ACE/ace/config-win32-msvc-145.h`, `ACE/ace/config-win32-msvc.h`	Introduce `config-win32-msvc-145.h` (defines `ACE_WIN32_VC145`) and update `_MSC_VER` checks to include the new header when `_MSC_VER >= 1950`, falling back to the existing 143 header otherwise.
MakeProjectCreator feature file `ACE/bin/MakeProjectCreator/config/vs2026.features`	Add VS2026 feature flags: `ssl=0`, `qos=1`, `rwho=0`, `sctp=0`.
MakeProjectCreator nmake config `ACE/bin/MakeProjectCreator/config/vs2026nmake.mpb`	Add nmake-specific configuration: remove `/Wp64` and `/Gm`, and suppress VC warnings 4456/4458/4459 for the nmake backend.
Release notes `ACE/NEWS`	Add NEWS bullet announcing Visual Studio 2026 support.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

DOCGroup/ACE_TAO#2390: Similar CI workflow updates adding/adjusting Visual Studio toolset entries.

Suggested reviewers

jwillemsen

Poem

🐰 Hop, a new toolset leaps in view,
VS2026, shiny and new.
Workflows updated, headers align,
Feature files tucked in a neat design.
I nibble the build and joyfully chew.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Add support for Visual Studio 2026' directly and accurately describes the primary change across all modified files, which collectively add VS 2026 configuration to CI workflows, build systems, and compiler configuration headers.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jwillemsen · 2026-03-04T09:57:47Z

Have you done a full build with tests? On github CI we only compile a small part of the code and don't run tests at all.

hwangsihu · 2026-03-04T10:29:42Z

Hi.

Sorry, is there any documentation on building ACE and TAO? I can't find it.

jwillemsen · 2026-03-04T10:34:50Z

See https://htmlpreview.github.io/?https://github.com/DOCGroup/ACE_TAO/blob/master/ACE/ACE-INSTALL.html, at the bottom there are some instructions to build from git. Without a full build/test I think it is too early to say Visual Studio 2026 is supported, maybe it compiles the core, but the real test is a full build/test and also look at warnings and runtime test results.

jwillemsen · 2026-03-04T13:54:29Z

Depends on DOCGroup/MPC#242

hwangsihu · 2026-03-04T15:24:25Z

Okay, Seems good.

jwillemsen · 2026-03-05T08:39:40Z

 feature(ace_languagestandard2017) {
-  specific(vs2017,vs2019,vs2022) {
+  specific(vs2017,vs2019,vs2022,vs2026) {
    LanguageStandard = stdcpp17


Don't think vs2026 needs this overwritten standard version

CI tests in DOCGroup/MPC#242 failed because this option was missing. Will merging the PR with this option removed solve the problem?

The default C++ version for Visual Studio 2026 is C++20 as far as I can determine from public documentation, so something to investigate and test more.

jwillemsen · 2026-03-05T08:40:00Z

+
+feature(ace_languagestandard2017) {
+  specific(nmake) {
+    compile_flags += /std:c++17


think this feature is not necessary

codacy-production · 2026-05-13T10:10:43Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results

Complexity 0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

hwangsihu marked this pull request as draft March 4, 2026 10:37

hwangsihu marked this pull request as ready for review March 4, 2026 15:24

jwillemsen reviewed Mar 5, 2026

View reviewed changes

jwillemsen reviewed Mar 6, 2026

View reviewed changes

Comment thread ACE/tests/OneByteFile Outdated

hwangsihu force-pushed the master branch from 0e30fbf to fcf88ad Compare March 6, 2026 13:06

hwangsihu added 2 commits May 13, 2026 18:45

Add support for Visual Studio 2026

eaa7ca1

Remove C++17 language standard override for vs2026

0e0c29f

hwangsihu force-pushed the master branch from a0b4738 to 0e0c29f Compare May 13, 2026 10:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Visual Studio 2026#2509

Add support for Visual Studio 2026#2509
hwangsihu wants to merge 2 commits into
DOCGroup:masterfrom
hwangsihu:master

hwangsihu commented Mar 4, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

hwangsihu commented Mar 4, 2026

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

hwangsihu commented Mar 4, 2026

Uh oh!

jwillemsen Mar 5, 2026

Uh oh!

hwangsihu Mar 5, 2026

Uh oh!

jwillemsen Mar 5, 2026

Uh oh!

jwillemsen Mar 5, 2026

Uh oh!

Uh oh!

codacy-production Bot commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

hwangsihu commented Mar 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

hwangsihu commented Mar 4, 2026

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

jwillemsen commented Mar 4, 2026

Uh oh!

hwangsihu commented Mar 4, 2026

Uh oh!

jwillemsen Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

hwangsihu Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

jwillemsen Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

jwillemsen Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codacy-production Bot commented May 13, 2026

Up to standards ✅

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

hwangsihu commented Mar 4, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 4, 2026 •

edited

Loading